Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doAction to not expect a response #153

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Update doAction to not expect a response #153

merged 1 commit into from
Apr 27, 2018

Conversation

dramich
Copy link
Contributor

@dramich dramich commented Apr 27, 2018

Problem:
doAction assumes that an action would have a response body which causes
JSON unmarshal errors

Solution:
Only attempt to Unmarshal when a response is expected

@dramich
Update doAction to not expect a response
5907ca4 
Problem:
doAction assumes that an action would have a response body which causes
JSON unmarshal errors

Solution:
Only attempt to Unmarshal when a response is expected
@ibuildthecloud ibuildthecloud merged commit 98500d1 into rancher:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dramich @ibuildthecloud