List and Get retry logic #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjellick
force-pushed
the
if-at-first-you-dont-succeed
branch
from
03d294e to
cb101c6
Compare
| for i := 0; i < 3; i++ { | ||
| req := s.common(namespace, k8sClient.Get()) | ||
| start := time.Now() | ||
| err = req.Do().Into(resultList) |
There was a problem hiding this comment.
you should (re)initialize resultList here to avoid odd behavior.
Some cloud provider k8s APIs have random timeouts on listing and getting. This change introduces a retry on lists and gets.
cjellick
force-pushed
the
if-at-first-you-dont-succeed
branch
from
cb101c6 to
bf6cd6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cloud provider k8s APIs have random timeouts on listing and getting.
This change introduces a retry on lists and gets