Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Frame-Options header #255

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Add Frame-Options header #255

merged 1 commit into from
Feb 15, 2019

Conversation

dramich
Copy link
Contributor

@dramich dramich commented Feb 15, 2019

Problem:
Frame-Options header is not being set, this is a potential secutiry
issue

Solution:
Set the header "X-Frame-Options:deny"

@dramich
Add Frame-Options header
b9b8921 
Problem:
Frame-Options header is not being set, this is a potential secutiry
issue

Solution:
Set the header "X-Frame-Options:deny"
@nathan-jenan-rancher
Copy link
Contributor

LGTM

@cjellick cjellick merged commit 9ba19df into rancher:master Feb 15, 2019
@dramich
Copy link
Contributor Author

dramich commented Feb 19, 2019

Issue: https://github.com/rancherlabs/rancher-security/issues/35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dramich @nathan-jenan-rancher @cjellick