Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass delete options in proxy store #293

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Conversation

gitlawr
Copy link
Contributor

@gitlawr gitlawr commented Jul 23, 2019

Address issue: rancher/rancher#17823

Problem:
There is no way to pass gracePeriodSeconds for force deletion

Solution:
Get deletion options in query params and pass it in proxy store

More Infos:

  1. In this solution, The APIs do force deletion by passing gracePeriodSeconds=0, which is the same way as apiserver.
  2. Kubernetes apiserver accepts delete options from entity-body of DELETE requests before v1.4, and support both query params and entity-body since v1.4. Because the usage of request body in DELETE request is kinda discouraged in HTTP/1.1 semantics and not supported by some clients. However, kubectl still pass deletion options to apiserver using request body. Refer to this issue for details.
  3. This pr reuses ParameterCodec utilities which is how apiserver processes the deletion options, see

Problem:
There is no way to pass gracePeriodSeconds for force deletion

Solution:
Get deletion options in query params and pass it in proxy store
@orangedeng
Copy link
Contributor

LGTM

2 similar comments
@rmweir
Copy link
Contributor

rmweir commented Aug 2, 2019

LGTM

@ibuildthecloud
Copy link
Contributor

LGTM

@cjellick cjellick merged commit f7bdda7 into rancher:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants