Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backgroud
We sometimes faced the panic
fatal error: concurrent map read and map write
orfatal error: concurrent map iteration and map write
.Investigation
we found the current lock is not enough:
this line seems wanted to copy but it's not copy because it's map.
and then, we have the possibility to face a panic like below
concurrent map read and map write
:concurrent map iteration and map write
:What is this PR
This PR fixes the above issue by extending lock to the end of this function.