Better support for subtyping #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2018 19:28
Change key method (used to find CRD that backs the schema) to use baseType of the schema when it differs from the schema ID. This will allow subtypes to use their base type's CRD store. When creating CRD stores, do not create one for a schema if it is a baseType.
We now have resources (subtypes of authConfig) that can be retrieved by ID but their collections are not viewable. This change is needed to suppport that.
cjellick
force-pushed
the
auth-config2
branch
from
e871e0f to
65807e9
Compare
cjellick
commented
Feb 1, 2018
| } | ||
| handler = apiRequest.Schema.ListHandler | ||
| nextHandler = s.Defaults.ListHandler | ||
| case http.MethodPost: | ||
| if !apiRequest.AccessControl.CanCreate(apiRequest, apiRequest.Schema) { | ||
| return apiRequest, httperror.NewAPIError(httperror.PermissionDenied, "Can not create "+apiRequest.Schema.Type) | ||
| return apiRequest, httperror.NewAPIError(httperror.PermissionDenied, "Can not create "+apiRequest.Schema.ID) |
There was a problem hiding this comment.
Schema.Type is "/something/something/schema". ID is what we want
jordanjean
pushed a commit
to jordanjean/norman
that referenced
this pull request
Jan 7, 2020
Added container_resource_limit and pod_security_policy_template_id arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.