Add method to expose register metrics #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics can only be registered through a magic environment variable, this enables users to run: metrics.Register() in main() to register metrics for collection. Tested with inlets Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
|
@dramich will this impact Rancher’s metics configuration? |
|
I'll let @dramich answer, but no, It retains the existing behaviour. |
dramich
approved these changes
Oct 12, 2020
|
Thank you @dramich, would you mind rebasing onto the testing branch too? We are likely to switch over to that to support -> https://github.com/inlets/inlets/pull/178 |
alexellis
added a commit
to alexellis/remotedialer
that referenced
this pull request
Oct 12, 2020
Merge commit '6838081e828c56941066d42e5865dc0b0ded8574' into testing Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
dramich
added a commit
that referenced
this pull request
Oct 12, 2020
Add #24 to testing branch via a merge commit
bleckh. i missed where you call Register() at the end of that if block (was reviewing from phone). Anyway, thanks for merging dan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics can only be registered through a magic environment
variable, this enables users to run:
metrics.Register() in main() to register metrics for
collection.
Tested with inlets
Signed-off-by: Alex Ellis (OpenFaaS Ltd) alexellis2@gmail.com