Configurable images #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelsayed
force-pushed
the
configurable_images
branch
2 times, most recently
from
cb7f68a to
7a605c3
Compare
moelsayed
force-pushed
the
configurable_images
branch
2 times, most recently
from
a25df8b to
b3274d2
Compare
moelsayed
force-pushed
the
configurable_images
branch
2 times, most recently
from
2532e03 to
2a8ddc6
Compare
alena1108
reviewed
Dec 4, 2017
cluster.yml
Outdated
| @@ -49,6 +51,16 @@ services: | |||
| kubeproxy: | |||
| image: rancher/k8s:v1.8.3-rancher2 | |||
|
|
|||
|
|
|||
| rke_images: | |||
There was a problem hiding this comment.
lets call it system_images, rke is a bit redundant
alena1108
reviewed
Dec 4, 2017
addons/kubedns.go
Outdated
| @@ -17,7 +17,7 @@ spec: | |||
| spec: | |||
| containers: | |||
| - name: autoscaler | |||
| image: gcr.io/google_containers/cluster-proportional-autoscaler-amd64:1.0.0 | |||
| image: ` + kubeDNSConfig["autoscaler_image"] + ` | |||
There was a problem hiding this comment.
We should define images names as constants. To avoid repeating them in the code
alena1108
reviewed
Dec 4, 2017
cluster/cluster.go
Outdated
| // don't break if the user didn't define rke_images | ||
| c.RKEImages = make(map[string]string) | ||
| } | ||
| setDefaultIfEmptyMapValue(c.RKEImages, "alpine", DefaultAplineImage) |
There was a problem hiding this comment.
Consider doing it in some kind of a loop, there is a lot of repeatable stuff. When you read the config, you can put all images in a map, then iterate over this map
moelsayed
force-pushed
the
configurable_images
branch
6 times, most recently
from
b14d732 to
27308dc
Compare
Refactor configuration defaults Add comments to config Add configurable utility images Add configurable network plugin images Add configurable kubedns images
moelsayed
force-pushed
the
configurable_images
branch
from
27308dc to
0ee002b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84