add dynamic configmap-nodelocal

[letnab]

add dynamic to configmap node-local-dns

[brandond]

You need to bump the packageVersion when changing the chart patches, if you are not also pulling in a new chart version from upstream:

rke2-charts/packages/rke2-coredns/package.yaml

Line 2 in 0e59454

packageVersion: 02

[brandond]

Thanks for the contribution. One nit on the whitespace.

Can you please open an issue at https://github.com/rancher/rke2/issues describing your use case, and provide example chart values to allow our QA team to test this change?

[brandond]

Can you show example values for how to use this?

You should also patch the values.yaml to show where in the nodelocal section the new values to configure this should be set:

rke2-charts/charts/rke2-coredns/rke2-coredns/1.29.002/values.yaml

Lines 388 to 399 in ca72e83

	nodelocal:
	enabled: false
	ip_address: "169.254.20.10"
	ipvs: false
	image:
	repository: rancher/hardened-dns-node-cache
	tag: "1.22.28-build20240125"
	initimage:
	repository: rancher/hardened-dns-node-cache
	tag: "1.22.28-build20240125"
	nodeSelector:
	kubernetes.io/os: linux

If the section shouldn't be present by default, add it commented out - for example:

rke2-charts/charts/rke2-coredns/rke2-coredns/1.29.002/values.yaml

Lines 374 to 378 in ca72e83

	# optional array of sidecar containers
	extraContainers: []
	# - name: some-container-name
	# image: some-image:latest
	# imagePullPolicy: Always

[brandond]

I tried just copying the default servers value under the nodelocal section, and it does not appear to actually work:

nodelocal:
  enabled: true
  servers:
  - plugins:
    - name: errors
    - configBlock: lameduck 5s
      name: health
    - name: ready
    - configBlock: |-
        pods insecure
        fallthrough in-addr.arpa ip6.arpa
        ttl 30
      name: kubernetes
      parameters: cluster.local in-addr.arpa ip6.arpa
    - name: prometheus
      parameters: 0.0.0.0:9153
    - name: forward
      parameters: . /etc/resolv.conf
    - name: cache
      parameters: 30
    - name: loop
    - name: reload
    - name: loadbalance
    port: 53
    zones:
    - zone: .

Error: UPGRADE FAILED: template: rke2-coredns/templates/_helpers.tpl:260:5: executing "nodelocalUpstreamDNSServerIP" at <include "clusterDNSServerIP" .>: error calling include: template: rke2-coredns/templates/_helpers.tpl:239:36: executing "clusterDNSServerIP" at <.Values.global.clusterDNS>: invalid value; expected string