Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about embedded registry #296

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Add information about embedded registry #296

merged 1 commit into from
Dec 21, 2024

Conversation

manuelbuil
Copy link
Contributor

This PR:

  • Adds information about the embedded registry (mostly copied from k3s)
  • Includes extra information about private registries (thanks @dereknola )

@manuelbuil manuelbuil requested a review from a team as a code owner December 18, 2024 11:06
@manuelbuil manuelbuil mentioned this pull request Dec 18, 2024
Open
dereknola
dereknola requested changes Dec 18, 2024
View reviewed changes
docs/install/airgap.md Outdated Show resolved Hide resolved
docs/install/airgap.md Outdated Show resolved Hide resolved
docs/install/registry_mirror.md Outdated Show resolved Hide resolved
docs/install/registry_mirror.md Show resolved Hide resolved
@manuelbuil manuelbuil force-pushed the addEmbeddedReg branch 6 times, most recently from 7c53e92 to 5b4eb5d Compare December 19, 2024 17:22
@manuelbuil manuelbuil mentioned this pull request Dec 19, 2024
Merged
brandond
brandond requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nit on the private registry stuff ;)

docs/install/airgap.md Outdated Show resolved Hide resolved
@manuelbuil manuelbuil requested a review from brandond December 19, 2024 21:25
@manuelbuil
Copy link
Contributor Author

Let me remove the exerimental/GA message from the airgap.md and leave it in the embeded-registry.md. It should be enough to have it in one place

@manuelbuil
Add information about embedded registry
fd28b2f 
Signed-off-by: manuelbuil <mbuil@suse.com>
@manuelbuil manuelbuil merged commit 166e15e into rancher:main Dec 21, 2024
1 check passed
@manuelbuil manuelbuil deleted the addEmbeddedReg branch December 21, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereknola dereknola dereknola approved these changes

@brandond brandond brandond approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelbuil @brandond @dereknola