Improve static pod probing #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
brandond
force-pushed
the
static_pod_readiness
branch
2 times, most recently
from
93ea56f to
b79814e
Compare
brandond
changed the title
dereknola
requested changes
Aug 2, 2022
brandond
force-pushed
the
static_pod_readiness
branch
2 times, most recently
from
aae4f00 to
b1753a2
Compare
dereknola
requested changes
Aug 3, 2022
brandond
force-pushed
the
static_pod_readiness
branch
from
b1753a2 to
b365276
Compare
dereknola
approved these changes
Aug 3, 2022
brandond
force-pushed
the
static_pod_readiness
branch
2 times, most recently
from
1aca096 to
af82e7b
Compare
briandowns
reviewed
Aug 3, 2022
brandond
force-pushed
the
static_pod_readiness
branch
from
af82e7b to
3b78f3c
Compare
* Add Startup/Readiness probes * Sync default probne thresholds and timing with kubadm * Make probe thresholds and timing configurable from the CLI, using an interface similar to control-plane resources and requests Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
briandowns
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Improve static pod probing
--control-plane-probe-configuration=etcd-startup-initial-delay-seconds=42,kube-apiserver-readiness-period-seconds=15Types of Changes
Enhancement
Verification
See linked issue
Linked Issues
#3104
User-Facing Change
Further Comments