Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in error message #1416

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix typo in error message #1416

merged 1 commit into from
Oct 8, 2024

Conversation

nemobis
Copy link
Contributor

@nemobis nemobis commented Sep 25, 2024

Issue:

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

@crobby crobby self-assigned this Sep 27, 2024
@crobby crobby requested a review from a team October 8, 2024 15:13
bigkevmcd
bigkevmcd approved these changes Oct 8, 2024
View reviewed changes
Copy link

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can fix the error string formatting in a different PR, this works for me.

@crobby crobby merged commit 8356b63 into rancher:master Oct 8, 2024
1 check passed
@matttrach matttrach added this to the November Release 2024 milestone Oct 23, 2024
@matttrach
Copy link
Collaborator

This has merged and was released with v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobby crobby crobby approved these changes

@bigkevmcd bigkevmcd bigkevmcd approved these changes

Assignees

@crobby crobby

Labels
area/documentation team/collie version/rancher-v2.10 version/v6
Projects
None yet
Milestone
November Release 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@nemobis @matttrach @bigkevmcd @crobby