-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rancher/rancher and go client deps #959
Conversation
19af84a
to
12b668e
Compare
12b668e
to
5325e1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build failure doesn't seem to be related to the changes made here (its having a problem reaching the docker-socket, I restarted it for you). I found an older PR where the rancher dep is bumped and this looks to being doing the same thing, so LGTM as long as build passes and it works locally
edit: build is still failing, looks like it may be related to these changes
@kinarashah It appears that the build is failing with the edit: My go.sum was not updated due to the difference in how go 1.16 and 1.17 handle dependencies. I ran a |
38d4526
to
2a32c8a
Compare
2a32c8a
to
17edb5c
Compare
93f8e77
to
3f29d17
Compare
I had to bump several packages that were out of date in the tf provider go.mod. Golang has also been updated to 1.17. In addition, drone was failing with errors when using the latest golang alpine image `golang 1.17.3-alpine3.16 so @kinarashah and I updated the drone image to golang 1.17.3 and the build image to golang 1.17.3-alpine3.13 because of this issue docker-library/php#1177. We're suspicious there may be a problem with how drone runs the tf tests so I've commented out the tests in the GNU makefile. |
8d2083a
to
35dba43
Compare
So the build passed with commented out tests, which means there's an issue with how drone runs the tf tests. Will need to debug this and fix this before merging. |
35dba43
to
2fbdd42
Compare
Issue was flaky tests, unsurprisingly :) |
Issue: #922
I'm not exactly sure if this is the right way to do this, but we need to bump rancher to pull in the latest rke updates so ACI network provider support will work. @kinarashah