Enable CAAPF by default #1004
Merged
Enable CAAPF by default #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
caapf-enabled-by-default
branch
from
936b6e5 to
0d27b9d
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
caapf-enabled-by-default
branch
from
0d27b9d to
9f433ae
Compare
alexander-demicev
approved these changes
Jan 15, 2025
anmazzotti
approved these changes
Jan 15, 2025
|
Seems the nightly failure is not related to the missing CAAPF installation. Still seeing this error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enable CAAPF by default for all imported CAPI clusters.
Cluster or namespace may specify
cluster-api.cattle.io/disable-fleet-auto-importlabel to exclude it from automatic import process with fleet.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1002
Special notes for your reviewer:
Checklist: