Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove incorrect make target #1007

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

yiannistri
Copy link
Contributor

What this PR does / why we need it:

Makefile target docker-build-and-push-etcdrestore was removed in #897 . Also HELM_EXPERIMENTAL_OCI should not be required for Helm >= 3.8.0 and the Go compiler should not be needed since we're building inside a container.

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@yiannistri yiannistri requested a review from a team as a code owner January 16, 2025 10:16
@yiannistri yiannistri self-assigned this Jan 16, 2025
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yiannistri. LGTM

@yiannistri yiannistri merged commit 6710ad4 into rancher:main Jan 20, 2025
9 of 13 checks passed
@yiannistri yiannistri deleted the fix-nightly branch January 20, 2025 11:36
@furkatgofurov7
Copy link
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants