Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support deduplication when using ClusterctlConfig #1011

Merged

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Jan 17, 2025

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:
If new provider is added through clusterctlconfig:

  1. which does not exist in the current config map it will be added as new entry to configmap
  2. with new URL and if provider exists, it only updates the URL of that entry
  3. without any changes to URL and if provider exists, it stays as is without any changes.

I am planning to add tests as a follow up PR, since config.go anyways did not have a dedicated test file up until now.

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner January 17, 2025 10:58
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 force-pushed the clusterctlconfig-deduplication branch from 704a378 to a788d7b Compare January 17, 2025 11:02
@furkatgofurov7 furkatgofurov7 changed the title WIP: Support deduplication when using ClusterctlConfig Support deduplication when using ClusterctlConfig Jan 21, 2025
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add unit tests for the PR? Also you mentioned some kind of issue with bootstrap or control plane provider? Is this resolved? I see no changes since last commit @furkatgofurov7

LGTM otherwise

Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed "fixes" from the PR description so issue doesn't close. Tests can be added in a follow-up PR.

@alexander-demicev alexander-demicev merged commit a73ea91 into rancher:main Jan 21, 2025
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the clusterctlconfig-deduplication branch January 22, 2025 09:44
@furkatgofurov7
Copy link
Contributor Author

Can you please add unit tests for the PR? Also you mentioned some kind of issue with bootstrap or control plane provider? Is this resolved? I see no changes since last commit @furkatgofurov7

LGTM otherwise

No issues with bootstrap after I tested it properly and it is resolved. I will open a follow-up with unit tests addition.

@furkatgofurov7 furkatgofurov7 changed the title Support deduplication when using ClusterctlConfig ✨ Support deduplication when using ClusterctlConfig Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants