Re-enable CAPRKE2 template in e2e, updated to work with CAPI 1.9+ #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
added
area/testing
Danil-Grigorev
force-pushed
the
re-enable-rke2-e2e-1.9
branch
3 times, most recently
from
4e5cba9 to
674cac5
Compare
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
re-enable-rke2-e2e-1.9
branch
from
674cac5 to
da4843a
Compare
4 tasks
salasberryfin
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Thanks @Danil-Grigorev. It's great that we can finally have this back! I added a minor comment that can be ignored if you don't feel like it's relevant.
alexander-demicev
approved these changes
Jan 2, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After ~6 months the test being disabled due to memory issues observed in CI, latest set of changes seems to resolve the issue locally, allowing the agent to be scheduled on the nodes. Attempting to re-enable the test to run in pre-submits, again.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #965
Special notes for your reviewer:
Checklist: