Use correct binary path for snapshot/restore, adapt Tilt config #987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Tilt uses own process for building docker images, which does involve overriding built image
CMD
. This overlaps with the model etcd snapshot restore is currently following, where the image is the part of the regular turtles image, running under differentCMD
.This discrepancy causes e2e to fail, and
Tiltfile
based build to work without issues.Current change ensures that both
tilt up
andGINKGO_LABEL_FILTER=local make test-e2e
work without issues.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #974
Special notes for your reviewer:
Checklist: