Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add upstream support of JSON logging #95

Closed
dmpe opened this issue Oct 14, 2024 · 1 comment · Fixed by #96
Closed

add upstream support of JSON logging #95

dmpe opened this issue Oct 14, 2024 · 1 comment · Fixed by #96

Comments

@dmpe
Copy link
Contributor

dmpe commented Oct 14, 2024

Is your feature request related to a problem? Please describe.

Following containers have JSON support build in. It just needs to be enabled in the helm chart via some if/else construct.
So my question is: could it be done ?

and I also guess all images under https://github.com/rancher/vsphere-charts/blob/main/charts/rancher-vsphere-csi/values.yaml#L247

Example: csi attacher has added JSON logging in https://github.com/kubernetes-csi/external-attacher/blob/master/CHANGELOG/CHANGELOG-4.6.md version.

Describe the solution you'd like

I would like that all CSI containers log in JSON format, instead of default text format. It should also configurable in the helm chart.

Rancher GUI 2.9.2 + downstream cluster v1.30.4+rke2r1

@snasovich
Copy link
Collaborator

@dmpe , thank you for submitting this enhancement request.
I guess it should be possible by adding support to provide additional args to these containers via values.yaml (at a glance they should probably go here -

nodeDriverRegistrar:
repository: rancher/mirrored-sig-storage-csi-node-driver-registrar
tag: latest
imagePullPolicy: ""
resources: {}
#resources:
# limits:
# cpu: 100m
# memory: 256Mi
# requests:
# cpu: 50m
# memory: 128Mi
for registrar and Helm template around
args:
- "--v=5"
- "--csi-address=$(ADDRESS)"
- "--kubelet-registration-path=$(DRIVER_REG_SOCK_PATH)"
should be updated to use these additional args) - that's one of possible solutions. However, at this time this enhancement is not prioritized - but we welcome community contributions. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants