-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logging): add support for passing additional CSI container args #96
Conversation
@dmpe , I see you opened this draft PR - thank you for working on this enhancement. Before you go too far into implementing it, I'm wondering if it's a good idea to adopt a more generic approach where one can specify an array in something like |
Hi @snasovich, I have adjusted the PR as you suggested. EDIT 1: wait, one more adjustment... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure that these are quoted
charts/rancher-vsphere-csi/templates/controller/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/rancher-vsphere-csi/templates/controller/deployment.yaml
Outdated
Show resolved
Hide resolved
charts/rancher-vsphere-csi/templates/controller/deployment.yaml
Outdated
Show resolved
Hide resolved
@dmpe , thank you for your contribution to this project. We're going to take care of getting these changes pulled in Rancher/RKE2 charts. |
Thank you @snasovich as well. Will be looking forward to the next release(s). |
Pull Request Checklist
Types of Change
Feature - adds support for additional args (which covers specifying logging format) of CSI containers
Linked Issues
tries to fix #95
After the PR is merged
Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.