Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): add support for passing additional CSI container args #96

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

dmpe
Copy link
Contributor

@dmpe dmpe commented Oct 22, 2024

Pull Request Checklist

  • Any new images or tags consumed by charts has been added here
  • Chart version has been incremented (if necessary)
  • That helm lint and pack run successfully on the chart.
  • Deployment of the chart has been tested and verified that it functions as expected.
  • Changes to scripting or CI config have been tested to the best of your ability

Types of Change

Feature - adds support for additional args (which covers specifying logging format) of CSI containers

Linked Issues

tries to fix #95

After the PR is merged

Once the PR is merged, typically upon a new release, the necessary teams will be notified via Slack hook to perform the RKE2 Charts and RKE2 changes. Any developer working on this issue is not responsible for updating RKE2 Charts or RKE2.

@dmpe dmpe requested review from a team as code owners October 22, 2024 11:14
@dmpe dmpe marked this pull request as draft October 22, 2024 11:15
@dmpe dmpe changed the title feat(json): add support for json feat(logging): add support for json logging in CSI containers Oct 22, 2024
@snasovich
Copy link
Collaborator

@dmpe , I see you opened this draft PR - thank you for working on this enhancement.

Before you go too far into implementing it, I'm wondering if it's a good idea to adopt a more generic approach where one can specify an array in something like .Values.csiNode.image.nodeDriverRegistrar.additionalArgs and have Helm template modified to append these additional arguments. This way it's possible to pass any arbitrary arguments and not just --logging-format=json.

@dmpe
Copy link
Contributor Author

dmpe commented Oct 24, 2024

Hi @snasovich, I have adjusted the PR as you suggested.

EDIT 1: wait, one more adjustment...
EDIT 2: ready for review

@dmpe dmpe marked this pull request as ready for review October 24, 2024 08:18
@dmpe dmpe changed the title feat(logging): add support for json logging in CSI containers feat(logging): add support for passing additional CSI container args Oct 24, 2024
@dmpe dmpe marked this pull request as draft October 24, 2024 08:24
@dmpe dmpe marked this pull request as ready for review October 24, 2024 08:32
Copy link
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure that these are quoted

@snasovich snasovich merged commit 1c52383 into rancher:main Oct 25, 2024
1 check passed
@snasovich
Copy link
Collaborator

@dmpe , thank you for your contribution to this project. We're going to take care of getting these changes pulled in Rancher/RKE2 charts.

@dmpe
Copy link
Contributor Author

dmpe commented Oct 25, 2024

Thank you @snasovich as well. Will be looking forward to the next release(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add upstream support of JSON logging
3 participants