migrate to github actions #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisonWAffel
force-pushed
the
gha-migration
branch
from
a17ff49
to
83762f7
Compare
HarrisonWAffel
force-pushed
the
gha-migration
branch
from
83762f7
to
104777d
Compare
jakefhyde
reviewed
May 22, 2024
| @@ -0,0 +1,46 @@ | |||
| <# | |||
There was a problem hiding this comment.
any reason why this ins't a mage target? just curious, I have 0 context around wins
There was a problem hiding this comment.
Wins doesn't have any docker utils that can be used easily by our mage files, and adding them may be a waste of time depending on how we want to standardize CI across all of the windows repos. So, yes it could be a mage target but for the sake of time and to avoid some of that work being undone in the future I opted for a simple powershell script instead.
jakefhyde
approved these changes
May 22, 2024
There was a problem hiding this comment.
Approving for sanity, but should probably have @aiyengar2 review for correctness
aiyengar2
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to migrate off of drone and onto github actions
Occurred changes and/or fixed issues
Drop drone file, add release workflow to github actions
A successful release run can be seen here: https://github.com/HarrisonWAffel/wins/actions/runs/9038294743
The resulting docker images are here: https://hub.docker.com/r/harrisonwaffel/wins/tags