Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.4.19] Dependency bumps, fix environment variables used by mage #247

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

HarrisonWAffel
Copy link
Contributor

  • Bumps several dependencies to the latest versions
  • Fixes the PR workflow to only run on PRs
  • Fixes the mage file to ensure the arch specified in NewGo is actually used. Currently, the host architecture is always being used as ARCH was being set instead of GOARCH

Notes:

  • github.com/Microsoft/hcsshim cannot be bumped at this time as the indirect github.com/prometheus dependencies rely on a type within the k8s.io/component-base dependency which was made private in 1.29. This is fixed in version v0.31.1. When we bump all k8s dependencies to v0.31.1 we can also bump github.com/Microsoft/hcsshim
  • A few other dependencies in the replace block have more recent versions, but have not been bumped so as to align with the latest versions used by the system-agent

@HarrisonWAffel HarrisonWAffel requested a review from a team September 19, 2024 19:17
@jiaqiluo jiaqiluo requested a review from a team September 20, 2024 23:36
@HarrisonWAffel
Copy link
Contributor Author

Merging with a single review as these are simple go.mod bumps and trivial updates to the mage tools

@HarrisonWAffel HarrisonWAffel merged commit 4293d68 into rancher:main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants