Android discovery refresh #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to be cleared from cache and rediscovered
|
I'll try this out later today or tomorrow. There's a couple nitpicky style changes I'll make, but the code looks functional. I have 3 Android devices I can try it out one |
|
Merged, made a few changes and will be available with next release. |
|
FYI, at least on Samsung Galaxy S7 with Android 7, setting clearCache: true results in discover() never calling callbacks and it just stays in 'discovering' state indefinitely (until you try connect() again) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android appears to cache discovered services (and subsequently characteristics and descriptors) at the system level. I found even removing and re-installing an app will not clear the cache. As such, I've added a boolean flag to the discover service, which when true calls an Android function to force re-discovery of the services.
A potential issue - some deeper googling indicates that some vendors remove this method from the bluetooth library. Perhaps they implement their own equivalent? In this case, it seems the function may not work on all android devices.