Skip to content

Commit

Permalink
Move the GCC and MSVC sanitizer builds to nightly
Browse files Browse the repository at this point in the history
Clang sanitizer build/test cycle is significantly faster and should
catch almost all issues. GH #4356
  • Loading branch information
randombit committed Oct 8, 2024
1 parent 00eb2d2 commit 6b34dea
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 7 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,16 +156,9 @@ jobs:
- target: coverage
compiler: gcc
host_os: ubuntu-24.04
- target: sanitizer
compiler: msvc
host_os: windows-2022
make_tool: ninja
- target: sanitizer
compiler: clang
host_os: ubuntu-24.04
- target: sanitizer
compiler: gcc
host_os: ubuntu-24.04
- target: valgrind
compiler: clang
host_os: ubuntu-24.04
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,44 @@ on:
- cron: '23 3 * * *'

jobs:
sanitizer:
name: "Sanitizers"
strategy:
fail-fast: false

matrix:
include:
- target: sanitizer
compiler: msvc
host_os: windows-2022
make_tool: ninja
- target: sanitizer
compiler: gcc
host_os: ubuntu-24.04

runs-on: ${{ matrix.host_os }}

steps:
- uses: actions/checkout@v4
with:
path: ./source

- name: Fetch BoringSSL fork for BoGo tests
uses: actions/checkout@v4
with:
repository: randombit/boringssl
ref: rene/runner-20240524
path: ./boringssl

- name: Setup Build Agent
uses: ./source/.github/actions/setup-build-agent
with:
target: ${{ matrix.target }}
cache-key: ${{ matrix.host_os }}-${{ matrix.compiler }}-x86_64-${{ matrix.target }}

- name: Build and Test Botan
run: python3 ./source/src/scripts/ci_build.py --root-dir=${{ github.workspace }}/source --build-dir=${{ github.workspace }}/build --boringssl-dir=${{ github.workspace }}/boringssl --cc='${{ matrix.compiler }}' --make-tool='${{ matrix.make_tool }}' --test-results-dir=junit_results ${{ matrix.target }}

x-compile:
name: "Cross"
strategy:
Expand Down

0 comments on commit 6b34dea

Please sign in to comment.