Refactor: less indirection for send_warning/fatal_alert()

randombit · Oct 25, 2021 · bf441e8 · bf441e8
1 parent e8c644e
commit bf441e8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/src/lib/tls/tls12/tls_channel_impl_12.h b/src/lib/tls/tls12/tls_channel_impl_12.h
@@ -89,16 +89,6 @@ class Channel_Impl_12 : public Channel_Impl
  */
  void send_alert(const Alert& alert) override;
 
- /**
- * Send a warning alert
- */
- void send_warning_alert(Alert::Type type) override { send_alert(Alert(type, false)); }
-
- /**
- * Send a fatal alert
- */
- void send_fatal_alert(Alert::Type type) override { send_alert(Alert(type, true)); }
-
  /**
  * Send a close notification alert
  */

diff --git a/src/lib/tls/tls_channel_impl.h b/src/lib/tls/tls_channel_impl.h
@@ -57,12 +57,12 @@ class Channel_Impl
  /**
  * Send a warning alert
  */
- virtual void send_warning_alert(Alert::Type type) = 0;
+ void send_warning_alert(Alert::Type type) { send_alert(Alert(type, false)); }
 
  /**
  * Send a fatal alert
  */
- virtual void send_fatal_alert(Alert::Type type) = 0;
+ void send_fatal_alert(Alert::Type type) { send_alert(Alert(type, true)); }
 
  /**
  * Send a close notification alert