-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TLS 1.3] Limited TLS 1.3 Client Implementation #2922
Merged
+10,266
−465
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0fd5ba1
Limited TLS 1.3 client implementation
651cc2b
refactor sig scheme validation in cert-verify msg
0cb56dd
minor code fixes
reneme 4f874ba
FIX: handle unimplemented handshake messages more gracefully
reneme a911560
FIX: potential segfault on API misuse in TLS 1.3
reneme 651a853
Clean up RFC 8448 test case
reneme 27abd98
remove dead code
reneme 70ac48a
FIX: unguarded nullptr when receiving an early close_notify
reneme afaf8bc
make Signature_Scheme a class
f03cfd9
review comments
reneme 2ed9cf0
Signature_Scheme::is_suitable_for and ::is_compatible_with
reneme 37eaa89
FIX: disambiguate invocation of stream operator
reneme b92d50e
Review Comment: move version specific implementations
reneme cd16328
Review Comments: fix style nits
reneme 9e17356
missing includes
reneme 0a7ad40
silence LGTM for readability
reneme 574b8f7
Handshake_Layer::copy_data() takes a secure_vector<>
reneme 57c70e4
Simplify keyshare extension parsing
reneme ebc62be
FIX: missing include
reneme a89c539
FIX: outdated TODO
reneme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client_Hello_13
infos in cli utilsWe'll need to allow deserializing a Client Hello w/o knowing if it'll be 1.2 or 1.3, just as we'll eventually need to do for the TLS 1.3 server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel, it would be fine to postpone that until the TLS 1.3 server is implemented.