Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TLS 1.3] Full Integration #2981

Closed
wants to merge 15 commits into from
Closed

[TLS 1.3] Full Integration #2981

wants to merge 15 commits into from

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented May 27, 2022

This contains the full integration of all pending TLS 1.3 feature branches. It's meant as a vehicle for integration testing on the CI, not for merging.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #2981 (8d0686a) into master (1522871) will increase coverage by 0.06%.
The diff coverage is 92.88%.

❗ Current head 8d0686a differs from pull request most recent head beff990. Consider uploading reports for the commit beff990 to get more accurate results

@@            Coverage Diff             @@
##           master    #2981      +/-   ##
==========================================
+ Coverage   92.57%   92.63%   +0.06%     
==========================================
  Files         577      599      +22     
  Lines       66744    70480    +3736     
  Branches     6391     6671     +280     
==========================================
+ Hits        61785    65288    +3503     
- Misses       4926     5159     +233     
  Partials       33       33
Impacted Files Coverage Δ
src/lib/tls/tls12/tls_channel_impl_12.cpp 89.04% <0.00%> (-0.81%) ⬇️
src/lib/tls/tls_algos.cpp 86.59% <0.00%> (+2.66%) ⬆️
src/lib/tls/tls_server.cpp 65.90% <0.00%> (-4.83%) ⬇️
src/lib/tls/tls_suite_info.cpp 100.00% <ø> (ø)
src/lib/utils/assert.cpp 100.00% <ø> (ø)
src/cli/tls_utils.cpp 77.64% <50.00%> (ø)
src/tests/tests.h 92.00% <50.00%> (-3.63%) ⬇️
src/cli/tls_client.cpp 74.41% <66.66%> (-0.59%) ⬇️
src/lib/tls/tls_extensions_cert_status_req.cpp 90.32% <71.42%> (-2.28%) ⬇️
src/lib/tls/tls12/tls_handshake_state.cpp 86.13% <75.00%> (-2.70%) ⬇️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1522871...beff990. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging b8cd79c into 1522871 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging 8d0686a into 1522871 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@lgtm-com
Copy link

lgtm-com bot commented May 27, 2022

This pull request introduces 1 alert when merging beff990 into 1522871 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@lgtm-com
Copy link

lgtm-com bot commented Jun 7, 2022

This pull request introduces 1 alert when merging 17c2e54 into db89870 - view on LGTM.com

new alerts:

  • 1 for Comparison result is always the same

@reneme reneme mentioned this pull request Jun 7, 2022
Merged
16 tasks
reneme and others added 15 commits July 6, 2022 14:30
@reneme
Extend TLS::Session to allow storing TLS 1.3 sessions
09f0343
@reneme
Extend TLS::Cipher:State to deal with PSKs in key schedule
7afc84a
@reneme
Implement resumption specific messages and extensions
f5cb32a 
* New_Session_Ticket
* PSK extension
* EarlyDataIndication extension
@reneme
Transcript_Hash_State automagically calculates truncated hashes where…
a690312 
… applicable
@reneme
Client/Server hello can deal with PSKs
2532b69
@reneme
Integrate session resumption into TLS 1.3 client
daa9274
@reneme
enable relevant BoGo tests for session resumption
dbf8840
@reneme
FIX: missing include
af88496
@reneme
AggregatedMessages helper class to coalesce messages
dceb6ff 
Co-Authored-By: Hannes Rantzsch <hannes.rantzsch@nexenio.com>
@reneme
Rename Handshake_State_13::sent -> ::sending
9ed8346 
After handshake messages are created they are dropped into this method for
book keeping and compile-time message type checking. Afterwards messages are
further processed and eventually sent. Hence, the old method name was fairly
misleading.

Co-Authored-By: Hannes Rantzsch <hannes.rantzsch@nexenio.com>
@reneme
TLS 1.3 Client Authentication in main handshake
0da7f0c 
This allows for client authentication using certificates in the main handshake.
Post-handshake authentication is out of scope of this commit

Co-authored-by: René Meusel <rene.meusel@nexenio.com>
@reneme
add TODO: support OCSP stapling for client auth
ad4bf51
@reneme
FIX: outdated TODO
8a1ad51
@reneme
Merge branch 'tls13/client_auth' into tls13/integration_new
89933f3
@reneme
Merge branch 'tls13/resumption' into tls13/integration_new
26b593c
@reneme
Copy link
Collaborator Author

reneme commented Sep 28, 2022

I just recreated this integration based on the current master (containing the basic TLS 1.3 client implementation).

@reneme
Copy link
Collaborator Author

reneme commented Oct 20, 2022

Closing, as all the integrated branches are now merged.

@reneme reneme closed this Oct 20, 2022
@randombit randombit deleted the tls13/integration branch January 1, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reneme @codecov-commenter