Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: silent module dependencies in TLS and XMSS tests #3632

Merged

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Jul 19, 2023

This fixes test failures due to unchecked missing modules for the following module constellation:

./configure.py --module-policy=bsi \
               --enable-modules=tls12,tls13,tls_cbc,pkcs11,xts
make tests
./botan-test --run-long-tests xmss_keygen_reference tls_extensions

xmss_keygen_reference silently depended on the availability of SHA-2 and/or SHAKE and tls_extensions silently required Curve25519.

@reneme reneme requested a review from lieser July 19, 2023 07:06
@coveralls
Copy link

Coverage Status

coverage: 91.702% (+0.01%) from 91.691% when pulling 165675d on Rohde-Schwarz:fix/silent_module_dependencies into 65b7548 on randombit:master.

@reneme reneme merged commit bfd60f0 into randombit:master Jul 20, 2023
33 checks passed
@reneme reneme deleted the fix/silent_module_dependencies branch July 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants