Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the pubkey operations wrapper types to move #3655

Merged
merged 3 commits into from
Aug 9, 2023
Merged

Allow the pubkey operations wrapper types to move #3655

merged 3 commits into from
Aug 9, 2023

Commits on Aug 4, 2023

  1. Allow the pubkey operations wrapper types to move 

    GH #3641
    @randombit
    randombit committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    60566b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. FIX: compilation of shared library in MSVC 

    For reasons the '= default' definition of the move c'tor and move
assignment is trying to instantiate the m_op's d'tor when compiling
a shared library with MSVC. This does not work inline, because the
PK_Ops::* class is just forward declared in the header.
    @reneme
    reneme committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    7e16655 View commit details
    Browse the repository at this point in the history

  2. appease clang-tidy

    @reneme
    reneme committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    acb76a8 View commit details
    Browse the repository at this point in the history