[TLS 1.3] Test Hybrid Schemes Online #3732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an online test in
test_cli.py
that attempts TLS 1.3 handshakes using hybrid PQ/T key exchange schemes against a number of pre-production services. Namely:To facilitate that, I adapted
./botan tls_client
to terminate with a non-zero status code if neither the peer nor us have sent/received a proper close_notify alert. Most notably: Handshake failures now result in a non-zero result code. Also thetest_cli()
helper method now supports an optionaltimeout
.The online tests are run only when
test_cli.py
is launched with--run-online-tests
. I did not reconfigure any CI configuration to do that so that we're not dependent on external (beta) services. @randombit Should we have some nightly that runs those tests?To try, after building the CLI, run this:
src/scripts/test_cli.py --run-online-tests $(pwd)/botan pqc
Closes #3731