Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TLS 1.3] Test Hybrid Schemes Online #3732

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Conversation

reneme
Copy link
Collaborator

@reneme reneme commented Oct 6, 2023

This introduces an online test in test_cli.py that attempts TLS 1.3 handshakes using hybrid PQ/T key exchange schemes against a number of pre-production services. Namely:

  • test.openquantumsafe.org
  • pq.cloudflareresearch.com, and
  • qsc.eu-de.kms.cloud.ibm.com.

To facilitate that, I adapted ./botan tls_client to terminate with a non-zero status code if neither the peer nor us have sent/received a proper close_notify alert. Most notably: Handshake failures now result in a non-zero result code. Also the test_cli() helper method now supports an optional timeout.

The online tests are run only when test_cli.py is launched with --run-online-tests. I did not reconfigure any CI configuration to do that so that we're not dependent on external (beta) services. @randombit Should we have some nightly that runs those tests?

To try, after building the CLI, run this:

src/scripts/test_cli.py --run-online-tests $(pwd)/botan pqc

Closes #3731

@coveralls
Copy link

Coverage Status

coverage: 91.693% (+0.005%) from 91.688% when pulling 870e008 on tls13/test_hybrid_schemes_online into 30ecb87 on master.

Copy link
Owner

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for digging into this. Nightly run of this seems good enough; I expect otherwise we'll get (more) flaky CI builds due to networking problems. We can do this in a followup.

@reneme reneme merged commit 870e008 into master Oct 6, 2023
37 checks passed
@reneme reneme deleted the tls13/test_hybrid_schemes_online branch October 9, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests against test.openquantumsafe.org fail for x25519/Kyber
3 participants