Attempted fix for Reverse Area 8 crash #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyceron
changed the title
ThanatosGit
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current attempt to fix the crash for Reverse Area 8 in RomFS mode. Related to #378
This solution currently checks if the Queen wall exists or not (essentially if RA8 is enabled or disabled). If the option is disabled, vanilla behavior occurs, and the ccs will update their setups when all the Metroids are dead. If it's enabled, never update the setups.
It would be nice to know why this breaks with RomFS mode and not PKG mode instead of doing this, as this is not the most elegant solution, but it does get the job done.