Add NTWK #133
Merged
Add NTWK #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquegemignani
force-pushed
the
feature/ntwk
branch
from
8f372a1
to
68674d8
Compare
duncathan
approved these changes
Jun 26, 2024
| return "NTWK" | ||
|
|
||
| def dependencies_for(self) -> typing.Iterator[Dependency]: | ||
| yield from [] |
There was a problem hiding this comment.
I don't think this is strictly true but it also doesn't affect paks or mlvls so whatever lol
There was a problem hiding this comment.
Could add a comment or even raise an Exception?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 68.08% 68.12% +0.03%
==========================================
Files 81 82 +1
Lines 5091 5113 +22
==========================================
+ Hits 3466 3483 +17
- Misses 1625 1630 +5 ☔ View full report in Codecov by Sentry. |
henriquegemignani
force-pushed
the
feature/ntwk
branch
from
68674d8
to
9d41085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.