Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PathFileProvider differing from IsoFileProvider #134

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

henriquegemignani
Copy link
Member

No description provided.

@henriquegemignani henriquegemignani added the bug Something isn't working label Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.68%. Comparing base (a38a56a) to head (7ae00ed).

Files Patch % Lines
src/retro_data_structures/asset_manager.py 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   68.57%   68.68%   +0.10%     
==========================================
  Files          82       82              
  Lines        5194     5195       +1     
==========================================
+ Hits         3562     3568       +6     
+ Misses       1632     1627       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@duncathan duncathan merged commit 2b6197f into main Jul 24, 2024
9 of 10 checks passed
@duncathan duncathan deleted the bugfix/path-file-provider branch July 24, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants