Support reading the headers for Corruption paks #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
+ Coverage 64.23% 64.76% +0.52%
==========================================
Files 75 76 +1
Lines 4949 4972 +23
==========================================
+ Hits 3179 3220 +41
+ Misses 1770 1752 -18
☔ View full report in Codecov by Sentry. |
henriquegemignani
force-pushed
the
feature/pak-corruption
branch
from
be6dc44
to
a685ba0
Compare
henriquegemignani
force-pushed
the
feature/pak-corruption
branch
from
a685ba0
to
471a50f
Compare
duncathan
requested changes
Sep 13, 2023
| PAKNoData = Struct( | ||
| _start=construct.Tell, | ||
| _header=PAKHeader, | ||
| table_of_contents=construct.Aligned(64, make_dict(Int32ub, construct.PaddedString(4, "ascii"))), |
There was a problem hiding this comment.
isn't this just a FourCC?
henriquegemignani
force-pushed
the
feature/pak-corruption
branch
from
471a50f
to
fb2720b
Compare
duncathan
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.