Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize creating AssetManager further #90

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

henriquegemignani
Copy link
Member

  • Loading Prime Remastered objects is slow (1+s of compiling code)
  • Decoding the resources section of the PAK is slow
  • Minor optmizations

Moves startup+AssetManager creation from 2.7s to 0.4s for me

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.02% ⚠️

Comparison is base (b0563d7) 64.24% compared to head (5333fd4) 64.23%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   64.24%   64.23%   -0.02%     
==========================================
  Files          75       75              
  Lines        4945     4949       +4     
==========================================
+ Hits         3177     3179       +2     
- Misses       1768     1770       +2     
Files Changed Coverage Δ
src/retro_data_structures/formats/pak_wiiu.py 43.75% <ø> (ø)
src/retro_data_structures/formats/room.py 50.44% <0.00%> (-1.35%) ⬇️
src/retro_data_structures/asset_manager.py 67.14% <100.00%> (-0.19%) ⬇️
src/retro_data_structures/formats/pak_gc.py 93.97% <100.00%> (+0.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henriquegemignani henriquegemignani merged commit 3479a71 into main Sep 13, 2023
9 of 10 checks passed
@henriquegemignani henriquegemignani deleted the feature/optimize-startup branch September 13, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants