💥 Configless operation #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to prepare for config-less operation, we need to process the command-line args before starting the main parts of the application. In order to make that work well, we only start a `DynamicSupervisor` intiially and then start the real supervisor later once we've processed the command-line arguments.
This sets the stage for specifying config options on the command line in addition to settings.
Sets the stage for allowing config settings to be passed on the command line.
- Rename new -> load_from_environment to make what's happening more explicit
- use a raw `%Config{}` struct where env loading isn't needed
- Eliminate duplicate specification of config defaults
- Inline AppConfig.fetch - separate module for this is overkill right now
So far, only the `--clear`/`--no-clear` option is supported; the rest will come in a later commit. Config options must come first and be separated from `mix test` options by a `--` separator. The pre-existing `--watch`/`--no-watch` flag can appear in either group for backwards-compatibility, but if it is specified after the `--` separator, a deprecation notice will be printed. OptionParser has built-in support for recognizing the `--` separator, but I was unable to take full advantage of that so that I could both preserve existing behavior and allow omitting the `--` separator when all arguments are intended for `mix test`.
This includes adding an `--exclude` option that now conflicts with mix test's option of the same name. I also realized that I've broken backwards-compatibility with the `watch`/`no-watch` option. I'll decide whether this feature warrants a major version bump and then either fix backwards-compatibility or remove the (not quite correct) handling of the legacy watch/no-watch option.
We've decided to make config-less operation a breaking change. Adjusting to it isn't terribly difficult and simplifies the code and maintenance burden.
Refactors CommandLineParser to return `:ok`/`:error` tuples.
- After calling OptionParser, do a pass to parse special values from strings (regexes and runner modules). This allows more helpful error messages - Then do a pass to combine `:keep`-style arguments into a single list to simplify config building
Modify the option value parsing logic to return :ok/:error tuples and use reduce_while to collect the results. There are still two `rescue` clauses, but they're used in order to nicely format error messages since formatting functions aren't exposed by `OptionParser` and `Regex`.
Only show usage information when requested. When there is an error, display a note about using --help instead.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 BREAKING CHANGE 💥
This PR modifies the way command-line arguments are parsed. If you have any predefined shell or mix aliases using
mix test.interactive's--no-watchoption ormix test's--excludeoption, you will need to update them. If you only pass othermix testoptions, those will continue to work as-is.Allow specifying all configuration options from the command line instead of/in addition to application config. This is useful in standard Elixir apps that no longer have a
config.exsfile by default. It also allows people to override configuration options as needed.Also adds
--helpand--versionoptions for convenience.See the updated documentation for details.