Ignore some filesystem events emitted by inotify #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The :isdir, :closed, and :attribute events likely don't need to be monitored to run tests, and at least the :attribute event is causing problems for projects that use the Domo library for validation. This is because the Domo library causes a delayed file read event to occur on some elixir files in the lib directory, which causes their atime attribute to be updated. This is happening after the test run kicks off, and then it causes a second test run to occur.
randycoulman
requested changes
Feb 21, 2024
lib/mix_test_interactive/watcher.ex
Outdated
| @@ -11,6 +11,8 @@ defmodule MixTestInteractive.Watcher do | |||
|
|
|||
| require Logger | |||
|
|
|||
| @ignore_events MapSet.new([:isdir, :closed, :attribute, :undefined]) | |||
There was a problem hiding this comment.
This list looks reasonable for Linux and Windows-based systems, but not for MacOS systems. The FSMac backend supports a significantly larger set of possible events.
I wonder if it would be better to instead list the events that we care about and then reverse the logic below. For the existing backends, that would likely be: [:created, :deleted, :modified, :removed, :renamed].
mix.exs
Outdated
| @@ -1,7 +1,7 @@ | |||
| defmodule MixTestInteractive.MixProject do | |||
| use Mix.Project | |||
|
|
|||
| @version "2.0.3" | |||
| @version "2.0.4-dev.1" | |||
There was a problem hiding this comment.
Please don't adjust the version number here. I'll do that as part of the release process.
Because the list of events that should trigger a test run is potentially much smaller than the list of all possible filesystem events, particularly on platforms such as MacOS, it is much simpler to specify the list of events we *do* want to process rather than the list of events we want to ignore. N.B. the `FileSystem` module does not completely normalize the names of the events between platforms, so our list of trigger events includes a few items that look similar in order to support all platforms.
randycoulman
approved these changes
Mar 5, 2024
Comment on lines
+21
to
+22
| :moved_from, | ||
| :moved_to, |
There was a problem hiding this comment.
Interesting! Which backend emits these two events? I didn't see them when I was looking at backends earlier.
|
Released in v2.0.4. Thanks again for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The :isdir, :closed, and :attribute events likely don't need to be monitored to run tests, and at least the :attribute event is causing problems for projects that use the Domo library for validation. This is because the Domo library causes a delayed file read event to occur on some elixir files in the lib directory, which causes their atime attribute to be updated. This is happening after the test run kicks off, and then it causes a second test run to occur.