Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix warnings when using Elixir 1.17 #89

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

jfpedroza
Copy link
Contributor

No description provided.

@randycoulman
Copy link
Owner

@jfpedroza Thanks for this PR! It looks like it will work to solve the issues, but it looks like there's a problem with CI. CircleCI hasn't release a Docker image with the tag 1.17 (yet?), so can't build on 1.17. I also note that they don't have any OTP 27.x images available yet.

Let me do some work on CI to make it possible to build on 1.17 and then I'll merge this. I'll try to get to this in the next few days.

Apply original changes from the CircleCI config to the new GitHub actions config.
@randycoulman randycoulman merged commit b3514c4 into randycoulman:main Jul 13, 2024
6 checks passed
@randycoulman
Copy link
Owner

Thanks again for the contribution! I'll get a new release out shortly containing this fix.

@jfpedroza jfpedroza deleted the fix-1.7-warnings branch July 13, 2024 22:35
@jfpedroza
Copy link
Contributor Author

Thanks!

@randycoulman
Copy link
Owner

Released as v2.1.0. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants