-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New bookmark backend + UI #92
base: master
Are you sure you want to change the base?
Conversation
- add `library-symbolic` to icons
- modify `open_in_new_tab` to allow automatically switching to opened tab - update `open-in-new-tab` signal in signals vector (hypertext.rs)
I appreciate it. |
I see, but I wanted to switch to TOML to allow users to set custom descriptions and tags for better organizing. Also, I will write migration code for users upgrading from older bookmarks format, so no manual migration will be needed. |
If there's an automatic migration, I approve |
- update `BookmarksWindow` UI file
@ranfdev This is the current draft structure for bookmarks file: [bookmark.1]
title = "TestSite0"
description = "Test Site no. 0"
url = "gemini://example.com"
[bookmark.2]
title = "TestSite1"
url = "gemini://example.com"
[bookmark.3]
title = "TestSite2"
description = "Test Site no. 2"
url = "gemini://example.com"
[bookmark.5]
title = "TestSite4"
description = "Test Site no. 4"
url = "gemini://example.com" Looks good? or would you like something changed? |
What's the advantage of using the syntax |
I think having an ID for a bookmark will make it easier to retrieve a particular bookmark struct in |
I think the |
I'll see. If I could make edit functionality to work reliably with vector indexes, then for simplicity (and for those who like fiddling with bookmark files), I will switch to |
Imagine if bookmarks had tags. At that point the new tab page could show bookmarks tagged with "new_tab", below the search bar similar to what Firefox is doing. Then you could add some default bookmarks with that tag, so that new users have an initial list of websites to discover the Gemini space |
@ranfdev I'll be splitting this PR into several smaller ones, as it will be easier for me to develop those changes one at the time (and for you to review them afterwards). |
This PR will contain an dedicated window for bookmarks management,
Add Bookmark
popover and redesigned bookmarks structure based on TOML file format.Things to do:
New Tab
viewAdd Bookmark
popover