Removing kitchen sink app and fixing router link #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeloor
approved these changes
Nov 26, 2019
Contributor
feeloor
left a comment
feeloor
left a comment
There was a problem hiding this comment.
Looks good, just minor comment.
| styleUrls: ['./base.component.css'] | ||
| selector: "app-routes-root", | ||
| templateUrl: "./base.component.html", | ||
| styleUrls: ["./base.component.css"] |
Contributor
There was a problem hiding this comment.
Could we use single quotation marks instead? Should we potentially add prettier to this repo?
Contributor
There was a problem hiding this comment.
Agreed, should be single quotes. Also the tslinter should catch that at compile time. It's a good one to have installed.
sumitarora
force-pushed
the
fix-removing-kitchen-sink
branch
from
5ca0195 to
a9ed923
Compare
sumitarora
force-pushed
the
fix-removing-kitchen-sink
branch
from
a9ed923 to
c470675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #97