This repository has been archived by the owner on May 25, 2021. It is now read-only.
fixing the settings close issue #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @danielschifano and @vanessayuenn to be potential reviewers |
| document.removeEventListener('click', this.resetTheme.bind(this), true); | ||
| } | ||
|
|
||
| openSettings() { |
There was a problem hiding this comment.
Since presumably these are not public APIs, is there any reason they couldn't be marked private or protected?
There was a problem hiding this comment.
correct we can but I won't do it on one component we can create an issue to do it for all the components just to be consistent in the code
|
@sumitarora LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix: #436