issue #684: console command sometimes throws error

[orizens]

This should fix issue #684.
It sends the current correct window object to the consoleReference Function each time.

[mention-bot]

@orizens, thanks for your PR! By analyzing the annotation information on this pull request, we identified @clbond, @sumitarora and @winkerVSbecks to be potential reviewers

[sumitarora]

💯 @hilaryhacksel ❓

[hilaryhacksel]

Hi @orizens, thanks so much for looking into this. I tried testing your fix and I'm still seeing this issue?

My mistake, didn't repo properly, works great! 👍

[orizens]

hi @hilaryhacksel - well, you're right.
perhaps i had caching issues. i'm checking into that.

[hilaryhacksel]

Thanks @orizens !

[orizens]

@hilaryhacksel
It seems like there's another ghost "instance" of the same window.
In this screenshot, i added a dummy property "WINDOW_OREN" (as an object) while in "this.consoleReference" (this is the ghost instance of window). This window has the url of augury demo page (augury.io..).
Later, in the console, when i try to reference the "WINDOW_OREN" in document, it is undefined.
So - I'm stuck with the question why there are 2 instances of the same window.

[stevenkampen]

@hilaryhacksel @orizens, I've not been able to reproduce this repeatably (only 3 or 4 time now out of about 400 tries). However, for others it's far more common, so as long as someone in that position says the fix works for them, then I think we're good. @hilaryhacksel The fix does work for you right?

[orizens]

@stevenkampen i'm able to reproduce this issue after cleaning the cache, closing the demo page on which i check it and open a new tab with it.
unfortunately, the fix i applied is not the answer.
As I indicated before, there seem be another instance of a window object which includes the same dom but its not the visible window that this extension needs to operate on.

[stevenkampen]

@orizens I can now reproduce this, and I've left the additional steps on the original issue. For me I had to make sure I was signed out of chrome (not just incognito even), and ensure that I'm opening the dev tools with "inspect element" rather than CMD + Shift + J (so the console tab isn't opened by default?). I'm going to use these clues to try to find the next step.

[stevenkampen]

Replaced with: #730