This repository has been archived by the owner on May 25, 2021. It is now read-only.
Resolve issue with KeyRegistry blowing up on applications with weird ES6 shims #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR should resolve #734 |
clbond
force-pushed
the
resolve-shim-issue
branch
from
4fbdf82
to
6ec29c4
Compare
igor-ka
approved these changes
Oct 18, 2016
clbond
force-pushed
the
resolve-shim-issue
branch
from
6ec29c4
to
70ef947
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues with sites like Asana.com which include weird ES6 shim implementations. Essentially this change prevents inclusion of Angular2 code before the ng-validate gate has been passed. (Prior to this change, Angular2 would be included as part of the dependency tree of ng-validate and caused exceptions on sites that use nonstandard ES6 shim implementations.)