enable typescript in project #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaboudi
commented
Jan 23, 2020
Comment on lines
+9
to
+23
| webpackFinal: async config => { | ||
| config.module.rules.push({ | ||
| test: /\.(ts|tsx)$/, | ||
| use: [ | ||
| { | ||
| loader: require.resolve('ts-loader'), | ||
| }, | ||
| { | ||
| loader: require.resolve('react-docgen-typescript-loader'), | ||
| }, | ||
| ], | ||
| }); | ||
| config.resolve.extensions.push('.ts', '.tsx'); | ||
| return config; | ||
| }, |
There was a problem hiding this comment.
It turns out that the typescript-preset actually has an error 🤦♀️. This manual step is required till the PR fix is merged in.
There was a problem hiding this comment.
For reference, here is the link to the related github issue: storybookjs/presets#65
alaboudi
commented
Jan 23, 2020
| @@ -0,0 +1,8 @@ | |||
| import * as React from "react"; | |||
There was a problem hiding this comment.
I'm trying to figure out how to write import React from "react" rather than import * as React from "react". If you know how, your contribution is welcomed 🙃
There was a problem hiding this comment.
Try #typescript on the rangle slack. Maybe it is not loading types correctly from node_modules/@types.
|
Looks great. |
alaboudi
force-pushed
the
enable-ts
branch
2 times, most recently
from
a5e66a1 to
27edc0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to use typescript in the design system