Skip to content

feat: migrate rabby to use hub #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025

Conversation

arlert-armin
Copy link
Contributor

@arlert-armin arlert-armin commented Mar 10, 2025

Summary

Rabby has been migrated to hub.

Fixes # (issue)

  • Added an optional switchOrAddNetwork parameter to the connect method. This change addresses the Rabby wallet’s behavior, which throws a different error code for "chain not found." Since other providers might exhibit similar inconsistencies, this optional callback allows custom handling of network switching or adding during connection.

How did you test this change?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Implemented a user interface (UI) change, referencing our Figma design to ensure pixel-perfect precision.

Copy link
Contributor

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tnx, I just added some comments.

@RyukTheCoder RyukTheCoder force-pushed the feat/rf-2201-add-can-eager-connect-to-namespaces branch from f707f82 to 673a8ce Compare March 16, 2025 08:22
Base automatically changed from feat/rf-2201-add-can-eager-connect-to-namespaces to next April 5, 2025 06:05
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch from b6081c3 to b52bdfc Compare April 5, 2025 16:29
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch from b52bdfc to 9a5f8a6 Compare April 13, 2025 09:06
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch from 9a5f8a6 to 2c3888c Compare May 31, 2025 10:00
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch 2 times, most recently from a455184 to 77870b7 Compare July 13, 2025 08:42
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch from 77870b7 to 0af3323 Compare July 13, 2025 09:26
@arlert-armin arlert-armin force-pushed the feat/rf-2317-migrate-rabby-to-use-hub branch 2 times, most recently from 24e0228 to efc9610 Compare July 13, 2025 10:59
Copy link
Contributor

@RyukTheCoder RyukTheCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a minor comment.

@RyukTheCoder RyukTheCoder merged commit e25ba8c into next Jul 13, 2025
5 checks passed
@RyukTheCoder RyukTheCoder deleted the feat/rf-2317-migrate-rabby-to-use-hub branch July 13, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants