-
Notifications
You must be signed in to change notification settings - Fork 35
feat: migrate rabby to use hub #1065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyukTheCoder
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tnx, I just added some comments.
1bf05c5
to
cd9d545
Compare
b60614f
to
4805c5a
Compare
RyukTheCoder
approved these changes
Mar 16, 2025
f707f82
to
673a8ce
Compare
Base automatically changed from
feat/rf-2201-add-can-eager-connect-to-namespaces
to
next
April 5, 2025 06:05
b6081c3
to
b52bdfc
Compare
b52bdfc
to
9a5f8a6
Compare
9a5f8a6
to
2c3888c
Compare
a455184
to
77870b7
Compare
77870b7
to
0af3323
Compare
24e0228
to
efc9610
Compare
RyukTheCoder
requested changes
Jul 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a minor comment.
efc9610
to
8c1adcb
Compare
RyukTheCoder
approved these changes
Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rabby has been migrated to hub.
Fixes # (issue)
switchOrAddNetwork
parameter to theconnect
method. This change addresses the Rabby wallet’s behavior, which throws a different error code for "chain not found." Since other providers might exhibit similar inconsistencies, this optional callback allows custom handling of network switching or adding during connection.How did you test this change?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: