feat: migrate coin98 to use Hub #992
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikasackermn
requested review from
Ikari-Shinji-re and
yeager-eren
as code owners
mikasackermn
assigned yeager-eren, RyukTheCoder and arlert-armin and unassigned yeager-eren, arlert-armin and RyukTheCoder
| } | ||
|
|
||
| const formatAccounts = result.accounts.map( | ||
| (account) => |
There was a problem hiding this comment.
Since you didn't specify the return type for getSolanaAccounts in utitls. this has an implicit any type. Please fix it in there or at least declare account as any explicitly.
|
It won't connect if you select the Solana namespace only. |
arlert-armin
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Coin98 has been migrated to hub
Fixes # (issue)
Checklist: