-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fetch balance for custom tokens #997
Open
Ikari-Shinji-re
wants to merge
3
commits into
next
Choose a base branch
from
feat/rf-1751-handle-balance-for-custom-tokens
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: fetch balance for custom tokens #997
Ikari-Shinji-re
wants to merge
3
commits into
next
from
feat/rf-1751-handle-balance-for-custom-tokens
+259
−129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7141e5d
to
b85efd9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
nikaaru
reviewed
Feb 11, 2025
This comment was marked as resolved.
This comment was marked as resolved.
you can use these custom tokens for the
|
And you can use these custom tokens for the
|
nikaaru
approved these changes
Feb 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to fetch the balances of custom tokens for wallets that support the corresponding blockchains whenever new custom tokens are added or a new wallet is connected.
Also implementing the retrieval of the token price from the balances response and updating the
usdValue
in the balance cache.Fixes # (issue)
How did you test this change?
You can add a custom token or connect a wallet that supports the blockchain of the custom tokens. A request will be sent to the server to fetch the balances of those tokens.
Sample test case:
3yoMkf3X6bDxjks6YaWwNk4SAbuaysLg1a4BjQKToQAA
Checklist: