Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to yew 0.19 #18

Merged
merged 5 commits into from
Feb 11, 2022
Merged

Update to yew 0.19 #18

merged 5 commits into from
Feb 11, 2022

Conversation

dcchut
Copy link
Contributor

@dcchut dcchut commented Feb 10, 2022

Notes:

  • Running cargo +nightly fmt generated a lot of whitespace changes in html!() calls, which is unfortunate.
  • Cow<'static, str> replaced with Option<AttrValue> since IntoPropValue is not implemented on Cow anymore.
  • InputData was removed from yew. I've made some (presumably quite dodgy) changes to handle this - this is probably worth having a closer look at.

Resolves #15

@ranile
Copy link
Owner

ranile commented Feb 11, 2022

Thanks for this PR! I don't think this crate was ever going to be updated if not for you doing it.

It would be great if you could also update mwc. All you have to do is update the npm package, invoke rollup and accommodate for breaking changes as described in the changelog. That can be a separate PR. I'll go ahead and merge this one.

@ranile ranile merged commit 1bfb89d into ranile:master Feb 11, 2022
@jens1205
Copy link

This PR is not yet available on crates.io? There I can only see 0.1.0

@ranile
Copy link
Owner

ranile commented May 30, 2022

Yes, it hasn't yet been published. If you want to use it, you need to use a git dependency:

material-yew = { git = "https://github.com/hamza1311/material-yew/", features = ["full"] }

@jens1205
Copy link

Thanks for the immediate response. yes, git dependency is working (first time I used this, so thanks for the opportunity :-))

Is anything preventing the official publishing of the new version?

@ranile
Copy link
Owner

ranile commented Jun 19, 2022

Hi, sorry for the very late response. I've published a new version.

cc @jens1205

@dcchut dcchut deleted the yew_019 branch June 21, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to migrate from yew 0.18 to 0.19
3 participants