Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranker1p4 #101

Merged
merged 15 commits into from
May 17, 2023
Merged

Ranker1p4 #101

merged 15 commits into from
May 17, 2023

Conversation

raynCovar
Copy link
Collaborator

@raynCovar raynCovar commented May 16, 2023

Updates to ranker to handle trapi 1.4 messages.

raynCovar added 2 commits May 15, 2023 19:15
…ut currently ignores auxillary graph until an auxillary graph example can be obtained
@raynCovar raynCovar requested a review from maximusunc May 16, 2023 12:43
ranker/shared/ranker_obj.py Show resolved Hide resolved
ranker/shared/ranker_obj.py Outdated Show resolved Hide resolved
@maximusunc maximusunc requested a review from uhbrar May 16, 2023 14:18
@cbizon
Copy link
Contributor

cbizon commented May 16, 2023

What does "auxilliary graphs are not fully considered" mean?

@raynCovar
Copy link
Collaborator Author

We don't currently have any responses to work off of so were planning to add it in after we can get a number of example responses

@cbizon
Copy link
Contributor

cbizon commented May 16, 2023

Yes, but we do have a spec for responses, right?

@raynCovar
Copy link
Collaborator Author

Yep, I'll finish it up - I am expecting some bugs when we do get them

Copy link
Contributor

@maximusunc maximusunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell!

Copy link
Contributor

@uhbrar uhbrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now.

@raynCovar raynCovar merged commit 4741e55 into master May 17, 2023
@maximusunc maximusunc deleted the ranker1p4 branch May 17, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants