Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trapi15 #130

Merged
merged 11 commits into from
Apr 12, 2024
Merged

Trapi15 #130

merged 11 commits into from
Apr 12, 2024

Conversation

cbizon
Copy link
Contributor

@cbizon cbizon commented Apr 11, 2024

I don't know if this is going to have any trouble with Abrar's changes, but the tests should now be active again.

@cbizon
Copy link
Contributor Author

cbizon commented Apr 11, 2024

It looks like the failing tests are omnicorp related & not TRAPI related. I'll take a closer look though.

@cbizon cbizon requested review from maximusunc and raynCovar and removed request for raynCovar April 11, 2024 18:51
@cbizon
Copy link
Contributor Author

cbizon commented Apr 11, 2024

OK, tests restored.

Copy link
Contributor

@maximusunc maximusunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There shouldn't be too much overlap with Abrar's PR, and it's probably a good thing to fix the tests before we get the other PR merged anyways.

@maximusunc maximusunc merged commit 5b3c6c2 into master Apr 12, 2024
1 check passed
@maximusunc maximusunc deleted the trapi15 branch April 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants